Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5582)

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 6288009: More installer refactoring in the interest of fixing some bugs and cleaning t... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_chrome_distribution.cc
===================================================================
--- chrome/installer/util/google_chrome_distribution.cc (revision 72487)
+++ chrome/installer/util/google_chrome_distribution.cc (working copy)
@@ -253,9 +253,9 @@
} // namespace
-GoogleChromeDistribution::GoogleChromeDistribution(
- const installer::MasterPreferences& prefs)
- : BrowserDistribution(prefs), product_guid_(kChromeGuid) {
+GoogleChromeDistribution::GoogleChromeDistribution()
+ : BrowserDistribution(CHROME_BROWSER),
+ product_guid_(kChromeGuid) {
}
// The functions below are not used by the 64-bit Windows binary -
@@ -633,7 +633,8 @@
// User qualifies for the experiment. Launch chrome with --try-chrome=flavor.
void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,
- const installer::Product& installation) {
+ const installer::Product& installation,
+ const FilePath& application_path) {
bool has_welcome_url = (flavor == 0);
// Possibly add a url to launch depending on the experiment flavor.
CommandLine options(CommandLine::NO_PROGRAM);
@@ -651,7 +652,7 @@
}
// Launch chrome now. It will show the toast UI.
int32 exit_code = 0;
- if (!installation.LaunchChromeAndWait(options, &exit_code))
+ if (!installation.LaunchChromeAndWait(application_path, options, &exit_code))
return;
// The chrome process has exited, figure out what happened.
@@ -688,10 +689,3 @@
base::LaunchApp(cmd, false, false, NULL);
}
#endif
-
-bool GoogleChromeDistribution::SetChannelFlags(
- bool set,
- installer::ChannelInfo* channel_info) {
- DCHECK(channel_info);
- return channel_info->SetChrome(set);
-}
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698