More installer refactoring in the interest of fixing some bugs and cleaning t...

chrome/installer/util/install_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // See the corresponding header file for description of the functions in this
 // file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include <algorithm>
 
+#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/values.h"
+#include "base/version.h"
 #include "base/win/registry.h"
 #include "base/win/windows_version.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/l10n_string_util.h"
-#include "chrome/installer/util/master_preferences_constants.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/installer/util/work_item_list.h"
 
 using base::win::RegKey;
-using installer::MasterPreferences;
 
 bool InstallUtil::ExecuteExeAsAdmin(const CommandLine& cmd, DWORD* exit_code) {
   FilePath::StringType program(cmd.GetProgram().value());
   DCHECK(!program.empty());
   DCHECK_NE(program[0], L'\"');
 
   CommandLine::StringType params(cmd.command_line_string());
   if (params[0] == '"') {
     DCHECK_EQ('"', params[program.length() + 1]);
     DCHECK_EQ(program, params.substr(1, program.length()));
@@ skipping 190 matching lines @@
   switch (status) {
     case installer::FIRST_INSTALL_SUCCESS:
     case installer::INSTALL_REPAIRED:
     case installer::NEW_VERSION_UPDATED:
     case installer::IN_USE_UPDATED:
       return 0;
     default:
       return status;
   }
 }
+
+// static
+void InstallUtil::MakeUninstallCommand(const std::wstring& exe_path,
+                                       const std::wstring& arguments,
+                                       CommandLine* command_line) {
+  const bool no_program = exe_path.empty();
+
+  // Return a bunch of nothingness.
+  if (no_program && arguments.empty()) {
+    *command_line = CommandLine(CommandLine::NO_PROGRAM);
+  } else {
+    // Form a full command line string.
+    std::wstring command;
+    command.append(1, L'"')
+        .append(no_program ? L"" : exe_path)
+        .append(L"\" ")
+        .append(arguments);
+
+    // If we have a program name, return this complete command line.
+    *command_line = CommandLine::FromString(command);
+  }
+}