More installer refactoring in the interest of fixing some bugs and cleaning t...

chrome/installer/util/channel_info.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_CHANNEL_INFO_H_
 #define CHROME_INSTALLER_UTIL_CHANNEL_INFO_H_
 #pragma once
 
 #include <string>
 
@@ skipping 23 matching lines @@
   bool Equals(const ChannelInfo& other) const {
     return value_ == other.value_;
   }
 
   // Determines the update channel for the value.  Possible |channel_name|
   // results are the empty string (stable channel), "beta", and "dev".  Returns
   // false (without modifying |channel_name|) if the channel could not be
   // determined.
   bool GetChannelName(std::wstring* channel_name) const;
 
+  // Returns true if |this| and |other| have a common base (that which remains
+  // when all modifiers and suffixes are omitted).

[robertshield, 2011/01/20 23:36:34]

|this| is somewhat unconventional. Replace with "this object".

[grt (UTC plus 2), 2011/01/21 05:27:51]

Done.

+  bool EqualsBaseOf(const ChannelInfo& other) const;
+
   // Returns true if the -CEEE modifier is present in the value.
   bool IsCeee() const;
 
   // Adds or removes the -CEEE modifier, returning true if the value is
   // modified.
   bool SetCeee(bool value);
 
   // Returns true if the -chrome modifier is present in the value.
   bool IsChrome() const;
 
@@ skipping 36 matching lines @@
   // modified.
   bool SetMultiFailSuffix(bool value);
 
  private:
   std::wstring value_;
 };  // class ChannelInfo
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_CHANNEL_INFO_H_