Prerendering for redirects -- part 2....

Prerendering for redirects -- part 2.

BUG=none
TEST=search for techcrunch and notice how the preloaded techcrunch.com is used despite the redirect


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71843

[tburkard, 2011-01-18 23:52:08]

Quick addendum:  This was supposed to be part of the redirect prerendering
change, but it was omitted accidentally (the file was not part of the change).

Please review this quick additional part to it.

[tburkard, 2011-01-19 00:00:53]

This change is not necessary to do the right thing on redirects in terms of
actually using a prerendered page.  However, this change speeds things up,
because it will swap in the prerendered page much earlier than if we wait until
all the redirects are resolved (or, even in the absence of redirects, if
DidNavigate has been fired).

[cbentzel, 2011-01-19 17:00:28]

I'm not familiar enough with TabContents or the IPC messages from the RenderView
which trigger these calls to be a good reviewer.

brettw, can you review? Should ben be on the list since it touches TabContents?

However, the description seems copied from the previous CL and may not be
appropriate here. It's basically deciding to use a prerendered page earlier than
in the past.

[cbentzel, 2011-01-19 17:08:03]

http://codereview.chromium.org/6288007/diff/1/chrome/browser/tab_contents/tab...
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/6288007/diff/1/chrome/browser/tab_contents/tab...
chrome/browser/tab_contents/tab_contents.cc:1641: PrerenderManager* pm =
profile()->GetPrerenderManager();
This block of code is now repeated three times - maybe move to a helper like

bool UsePreload()

[tburkard, 2011-01-19 19:00:45]

http://codereview.chromium.org/6288007/diff/1/chrome/browser/tab_contents/tab...
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/6288007/diff/1/chrome/browser/tab_contents/tab...
chrome/browser/tab_contents/tab_contents.cc:1641: PrerenderManager* pm =
profile()->GetPrerenderManager();
On 2011/01/19 17:08:03, cbentzel wrote:
> This block of code is now repeated three times - maybe move to a helper like
> 
> bool UsePreload()

Done.

[brettw, 2011-01-19 21:40:57]

LGTM