Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 6288004: remote_access.sh: remove dependence on ssh-agent (Closed)

Created:
9 years, 11 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

remote_access.sh: remove dependence on ssh-agent This is take 2 of this CL. Modified run_remote_test.sh to explicitly start an ssh-agent if necessary instead of implicitly relying on remote_access.sh to do it. BUG=n0ne TEST=Verified I could successfully ssh. Change-Id: I4e70b8574af1119dcf36768f6602ecc0cabedc31

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove bashism and add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M remote_access.sh View 1 3 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mandeep Singh Baines
9 years, 11 months ago (2011-01-13 23:57:55 UTC) #1
sosa
http://codereview.chromium.org/6288004/diff/1/remote_access.sh File remote_access.sh (right): http://codereview.chromium.org/6288004/diff/1/remote_access.sh#newcode120 remote_access.sh:120: : ???
9 years, 11 months ago (2011-01-14 17:12:30 UTC) #2
Mandeep Singh Baines
Added comment. PTAL. sosa@chromium.org (sosa@chromium.org) wrote: > > http://codereview.chromium.org/6288004/diff/1/remote_access.sh > File remote_access.sh (right): > > ...
9 years, 11 months ago (2011-01-14 17:46:22 UTC) #3
sosa
9 years, 11 months ago (2011-01-14 17:53:20 UTC) #4
LGTM

On Fri, Jan 14, 2011 at 9:46 AM, Mandeep Singh Baines <msb@chromium.org> wrote:
> Added comment. PTAL.
>
> sosa@chromium.org (sosa@chromium.org) wrote:
>>
>> http://codereview.chromium.org/6288004/diff/1/remote_access.sh
>> File remote_access.sh (right):
>>
>> http://codereview.chromium.org/6288004/diff/1/remote_access.sh#newcode120
>> remote_access.sh:120: :
>> ???
>>
>
> You can't have an empty function in bash. I don't want to remove this
> function because its called by clients and we may need to do some cleanup
> later. Rather than change the interface, I'm leaving this as an empty
> function.
>
> I've added a comment to make this clearer.
>
>> http://codereview.chromium.org/6288004/
>

Powered by Google App Engine
This is Rietveld 408576698