Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 6288003: Add option for url_fetch_test to wait for a JS expression (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., sjg, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add option for url_fetch_test to wait for a JS expression This option extends url_fetch_test to support waiting for a JavaScript expression to evaluate to true. This is used in the Chrome OS desktopui_GmailLatency test. The browser goes to the test URL and then runs the test to completion. BUG=chromium-os:10869 TEST=test on my workstation on Ubuntu, x86-mario, qemu using a web page which sets a JS value after a period. Original Review URL: http://codereview.chromium.org/6249003/ Signed-off-by: Simon Glass <sjg@chromium.org>; Reviewed-by: Anton Sargent <asargent@chromium.org>; Reviewed-by: William Chan <willchan@chromium.org>; Reviewed-by: Thiago Farina <tfarina@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71408

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M chrome/test/url_fetch_test/url_fetch_test.cc View 1 6 chunks +45 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tfarina
9 years, 11 months ago (2011-01-13 22:55:45 UTC) #1
FYI!

Powered by Google App Engine
This is Rietveld 408576698