Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mirror-debugger.js

Issue 6287041: Avoid callbacks to user code during error formatting in a couple of (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1077 */ 1077 */
1078 ErrorMirror.prototype.message = function() { 1078 ErrorMirror.prototype.message = function() {
1079 return this.value_.message; 1079 return this.value_.message;
1080 }; 1080 };
1081 1081
1082 1082
1083 ErrorMirror.prototype.toText = function() { 1083 ErrorMirror.prototype.toText = function() {
1084 // Use the same text representation as in messages.js. 1084 // Use the same text representation as in messages.js.
1085 var text; 1085 var text;
1086 try { 1086 try {
1087 str = builtins.ToDetailString(this.value_); 1087 str = %_CallFunction(this.value_, builtins.errorToString);
1088 } catch (e) { 1088 } catch (e) {
1089 str = '#<an Error>'; 1089 str = '#<Error>';
1090 } 1090 }
1091 return str; 1091 return str;
1092 } 1092 }
1093 1093
1094 1094
1095 /** 1095 /**
1096 * Base mirror object for properties. 1096 * Base mirror object for properties.
1097 * @param {ObjectMirror} mirror The mirror object having this property 1097 * @param {ObjectMirror} mirror The mirror object having this property
1098 * @param {string} name The name of the property 1098 * @param {string} name The name of the property
1099 * @param {Array} details Details about the property 1099 * @param {Array} details Details about the property
(...skipping 1271 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 } 2371 }
2372 if (!NUMBER_IS_FINITE(value)) { 2372 if (!NUMBER_IS_FINITE(value)) {
2373 if (value > 0) { 2373 if (value > 0) {
2374 return 'Infinity'; 2374 return 'Infinity';
2375 } else { 2375 } else {
2376 return '-Infinity'; 2376 return '-Infinity';
2377 } 2377 }
2378 } 2378 }
2379 return value; 2379 return value;
2380 } 2380 }
OLDNEW
« src/array.js ('K') | « src/messages.js ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698