Create specialized code stubs for PixelArray loads.

src/ia32/code-stubs-ia32.cc

Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 006ee46ed428c5e2e66c2a4d16611f42c4619f81..c8094a3aed619b4b68f144e65b3c282fe4557b27 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -6507,6 +6507,49 @@ void ICCompareStub::GenerateMiss(MacroAssembler* masm) {
 }
 
 
+// Loads a indexed element from a pixel array.
+void GenerateFastPixelArrayLoad(MacroAssembler* masm,
+                                Register receiver,
+                                Register key,
+                                Register elements,
+                                Register untagged_key,
+                                Register result,
+                                Label* not_pixel_array,
+                                Label* key_not_smi,
+                                Label* out_of_range) {
+  // Register use:
+  //   receiver - holds the receiver and is unchanged.
+  //   key - holds the key and is unchanged (must be a smi).
+  //   elements - is set to the the receiver's element if
+  //       the receiver doesn't have a pixel array or the
+  //       key is not a smi, otherwise it's the elements'
+  //       external pointer.
+  //   untagged_key - is set to the untagged key
+
+  // Key must be a smi.
+  if (key_not_smi != NULL) {

[Søren Thygesen Gjesse, 2011/02/01 12:02:56]

See comments for ARM. Also on ARM you check the receiver before the key, but of
cause that does not matter.

[danno, 2011/02/03 12:53:26]

Done.

+    __ test(key, Immediate(kSmiTagMask));
+    __ j(not_zero, key_not_smi, not_taken);
+  }
+  __ mov(untagged_key, key);
+  __ SmiUntag(untagged_key);
+
+  // Verify that the receiver has pixel array elements.

[Mads Ager (chromium), 2011/02/01 12:02:12]

Perform checks in the same order on all platforms for consistency? On ARM the
pixel array check is first.

[danno, 2011/02/03 12:53:26]

Done.

+  __ mov(elements, FieldOperand(receiver, JSObject::kElementsOffset));
+  __ CheckMap(elements, Factory::pixel_array_map(), not_pixel_array, true);
+
+  // Key must be in range.
+  __ cmp(untagged_key, FieldOperand(elements, PixelArray::kLengthOffset));
+  __ j(above_equal, out_of_range);
+
+  // Perform the indexed load and tag the result as a smi.
+  __ mov(elements, FieldOperand(elements, PixelArray::kExternalPointerOffset));
+  __ movzx_b(result, Operand(elements, untagged_key, times_1, 0));
+  __ SmiTag(result);
+  __ ret(0);
+}
+
+
 #undef __
 
 } }  // namespace v8::internal