Create specialized code stubs for PixelArray loads.

src/ic.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1186 matching lines @@
 
     return object->GetProperty(*object, &lookup, *name, &attr);
   }
 
   // Do not use ICs for objects that require access checks (including
   // the global object).
   bool use_ic = FLAG_use_ic && !object->IsAccessCheckNeeded();
 
   if (use_ic) {
     Code* stub = generic_stub();
-    if (object->IsString() && key->IsNumber()) {
-      stub = string_stub();
-    } else if (object->IsJSObject()) {
-      Handle<JSObject> receiver = Handle<JSObject>::cast(object);
-      if (receiver->HasExternalArrayElements()) {
-        MaybeObject* probe =
+    if (state == UNINITIALIZED) {
+      if (object->IsString() && key->IsNumber()) {
+        stub = string_stub();
+      } else if (object->IsJSObject()) {
+        Handle<JSObject> receiver = Handle<JSObject>::cast(object);
+        if (receiver->HasExternalArrayElements()) {
+          MaybeObject* probe =
             StubCache::ComputeKeyedLoadOrStoreExternalArray(*receiver, false);

[Mads Ager (chromium), 2011/02/01 12:02:12]

Four-space indent. Which will probably lead to a long line so you have to have
one argument per line as well. Urgh.

[danno, 2011/02/03 12:53:26]

Done.

-        stub =
+          stub =
             probe->IsFailure() ? NULL : Code::cast(probe->ToObjectUnchecked());
-      } else if (receiver->HasIndexedInterceptor()) {
-        stub = indexed_interceptor_stub();
-      } else if (state == UNINITIALIZED &&
-                 key->IsSmi() &&
-                 receiver->map()->has_fast_elements()) {
-        MaybeObject* probe = StubCache::ComputeKeyedLoadSpecialized(*receiver);
-        stub =
+        } else if (receiver->HasIndexedInterceptor()) {
+          stub = indexed_interceptor_stub();
+        } else if (receiver->HasPixelElements()) {
+          MaybeObject* probe =
+            StubCache::ComputeKeyedLoadPixelArray(*receiver);

[Mads Ager (chromium), 2011/02/01 12:02:12]

Four-space indent.

[danno, 2011/02/03 12:53:26]

Done.

+          stub =
             probe->IsFailure() ? NULL : Code::cast(probe->ToObjectUnchecked());

[Mads Ager (chromium), 2011/02/01 12:02:12]

Four-space indent.

[danno, 2011/02/03 12:53:26]

Done.

+        } else if (key->IsSmi() &&
+                   receiver->map()->has_fast_elements()) {
+          MaybeObject* probe =
+            StubCache::ComputeKeyedLoadSpecialized(*receiver);

[Mads Ager (chromium), 2011/02/01 12:02:12]

Ditto.

[danno, 2011/02/03 12:53:26]

Done.

+          stub =
+            probe->IsFailure() ? NULL : Code::cast(probe->ToObjectUnchecked());

[Mads Ager (chromium), 2011/02/01 12:02:12]

Reindent. We need four-space indent so in this case we should split at the ?:.

[danno, 2011/02/03 12:53:26]

Done.

+        }
       }
     }
     if (stub != NULL) set_target(stub);
 
 #ifdef DEBUG
     TraceIC("KeyedLoadIC", key, state, target());
 #endif  // DEBUG
 
     // For JSObjects with fast elements that are not value wrappers
     // and that do not have indexed interceptors, we initialize the
@@ skipping 1011 matching lines @@
 #undef ADDR
 };
 
 
 Address IC::AddressFromUtilityId(IC::UtilityId id) {
   return IC_utilities[id];
 }
 
 
 } }  // namespace v8::internal