Issue 6287020: Removes known crash that hasn't happened in the last 50 or so runs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6287020: Removes known crash that hasn't happened in the last 50 or so runs. (Closed)

Created:
9 years, 10 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removes known crash that hasn't happened in the last 50 or so runs. BUG=57188 TEST=none TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73159

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/test/data/reliability/known_crashes.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 10 months ago (2011-01-31 18:23:17 UTC) #2

Nice, LGTM

On Mon, Jan 31, 2011 at 10:14 AM, <sky@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Removes known crash that hasn't happened in the last 50 or so runs.
>
> BUG=57188
> TEST=none
> TBR=willchan
>
> Please review this at http://codereview.chromium.org/6287020/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/data/reliability/known_crashes.txt
>
>
> Index: chrome/test/data/reliability/known_crashes.txt
> diff --git a/chrome/test/data/reliability/known_crashes.txt
> b/chrome/test/data/reliability/known_crashes.txt
> index
>
f60a39c2e1d8e4ccf12b0a105788dc4467bda20e..7135576a1a726910ef9133df415b90496d8bee90
> 100644
> --- a/chrome/test/data/reliability/known_crashes.txt
> +++ b/chrome/test/data/reliability/known_crashes.txt
> @@ -89,9 +89,6 @@ PREFIX : `anonymous
> namespace'::invalidparameter____purecall___notificationservi
>  PREFIX : `anonymous
> namespace'::purecall____purecall___lockimpl::unlock___`anonymous
>
namespace'::rolloverprotectednow___lockimpl::lock___conditionvariable::signal___watchdog::armsometimedeltaago___`anonymous
> namespace'::jankobserverhelper::startprocessingtimers___`anonymous
> namespace'::uijankobserver::willprocesstask
>  PREFIX : `anonymous
> namespace'::invalidparameter____purecall___lockimpl::unlock___`anonymous
>
namespace'::rolloverprotectednow___lockimpl::lock___conditionvariable::signal___watchdog::armsometimedeltaago___`anonymous
> namespace'::jankobserverhelper::startprocessingtimers___`anonymous
> namespace'::uijankobserver::willprocesstask
>
> -# 57188
> -PREFIX : `anonymous
>
namespace'::invalidparameter____purecall___basetab::advanceloadinganimation___notificationservice::notify___`anonymous
> namespace'::painttimer::timeout
> -
>  # 57368
>  PREFIX :
>
appmodaldialog::closemodaldialog___javascriptappmodaldialog::observe___notificationservice::notify___tabcontents::~tabcontents
>
>
>
>

Expand Messages | Collapse Messages