Compare JSObjects by identity immediately.

Compare JSObjects by identity immediately.

When invoking EQUALS JS builtin, 1st argument is passed as a receiver and
if it's a global object, it gets overwritten with global proxy object and
thus one gets incorrect results.

BUG=v8::1082

Committed: http://code.google.com/p/v8/source/detail?r=6555

[antonm, 2011-01-31 16:14:01]

Mads,

may you have a look?

I am not quite satisfied with this CL: ideally I'd rather have 2-arguments
SAFE_EQUALS JS builtin or function which invokes EQUALS JS builtin (or vice
versa).  However I didn't manage to make JS bultins call each other.  And if I
make SAFE_EQUALS a plain JS function, it might trigger GC when getting lazily
compiled (which is no-no thanks to security checks).  So I ended up with this
special casing.  Any other ideas are most appreciated.

[Mads Ager (chromium), 2011-02-01 08:36:34]

LGTM

http://codereview.chromium.org/6287018/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6287018/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:12211: CHECK_EQ(1, global->StrictEquals(global));
Please use true and false instead of 1 and 0.

[antonm, 2011-02-01 12:43:12]

http://codereview.chromium.org/6287018/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6287018/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:12211: CHECK_EQ(1, global->StrictEquals(global));
On 2011/02/01 08:36:34, Mads Ager wrote:
> Please use true and false instead of 1 and 0.

Sure and should have done it myself.