Issue 6287012: Initialize values before calling ALSA APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6287012: Initialize values before calling ALSA APIs (Closed)

Created:
9 years, 11 months ago by davejcool

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos

Visibility:
Public.

Description

Initialize values before calling ALSA APIs There should no longer be uninitialized values reported when running CrOs build of Chrome on Linux with cross_fuzz under valgrind. I believe the ALSA APIs should have been initializing all these values, but to be sure they are now initialized before making the calls. BUG=chromium-os:11252 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72670

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/audio_mixer_alsa.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davejcool

Initializing values to a default before calling ALSA APIs should fix this.

9 years, 11 months ago (2011-01-25 22:04:51 UTC) #1

scherkus (not reviewing)

9 years, 11 months ago (2011-01-25 23:17:13 UTC) #2

LGTM

This change should probably be merged

Expand Messages | Collapse Messages