Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 6287008: Some spellcheck dictionary updates.... (Closed)

Created:
9 years, 11 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
brettw, Hironori Bono
CC:
chromium-reviews
Visibility:
Public.

Description

Some spellcheck dictionary updates. 1. Copy en_US.dic_delta to en_AU and en_GB so they get the additional words as well (such as 'Google'). 2. Generate new dics, call them version 1-2. 3. remove en-US.dic and en-US.aff (not sure why these exist alongside en_US.{aff,dic}. They are identical.) BUG=5509 TEST=none at the moment (later I will alter SpellCheckTest.SpellCheckText) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1038 lines) Patch
M README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A en-AU-1-2.dic View Binary file 0 comments Download
A en-GB-1-2.dic View Binary file 0 comments Download
D en-US.aff View 1 chunk +0 lines, -1040 lines 0 comments Download
D en-US.dic View Binary file 0 comments Download
A + en_AU.dic_delta View 0 chunks +-1 lines, --1 lines 0 comments Download
A + en_GB.dic_delta View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
9 years, 11 months ago (2011-01-21 00:15:27 UTC) #1
brettw
LGTM, note we'll need to push the new files to the server and after that ...
9 years, 11 months ago (2011-01-21 00:25:04 UTC) #2
Evan Stade
ok. I have the version list update ready, but I don't know how to push ...
9 years, 11 months ago (2011-01-21 00:28:38 UTC) #3
brettw
On Thu, Jan 20, 2011 at 4:28 PM, Evan Stade <estade@chromium.org> wrote: > ok. I ...
9 years, 11 months ago (2011-01-21 00:50:30 UTC) #4
Hironori Bono
9 years, 11 months ago (2011-01-21 01:52:14 UTC) #5
LGTM.

On 2011/01/21 00:50:30, brettw wrote:
> I think hbono knows. If not, I think mal might.

Unfortunately, I cannot upload dictionaries by myself. I recommend to ask
laforge, who can upload them.

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698