Issue 6287001: Put wait around remote_reboot core code itself rather than around the ping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6287001: Put wait around remote_reboot core code itself rather than around the ping. (Closed)

Created:
9 years, 11 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Put wait around remote_reboot core code itself rather than around the ping. The last CL had a race condition where we could ping but not run the reboot_check code. This CL moves to watch the reboot_check code rather than a ping. Change-Id: I8bdda97850ac085be9cf5dfb0b80fb7e1c8dd212 BUG=chromium-os:10867 TEST=Ran it 100 times without error. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bb4661d

Patch Set 1 #

Patch Set 2 : ws #

Patch Set 3 : readd comment #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -35 lines)			Patch
	M	remote_access.sh	View	1 2	3 chunks	+34 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

Retveld hates me and the diff is a lil ugly. The only real change is ...

9 years, 11 months ago (2011-01-13 03:17:23 UTC) #1

LGTM

Expand Messages | Collapse Messages