Issue 6286157: Test BMP files more thoroughly to be sure they're valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6286157: Test BMP files more thoroughly to be sure they're valid. (Closed)

Created:
9 years, 10 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

Test BMP files more thoroughly to be sure they're valid. This is work-in-progress. More tests to come... Change-Id: Id2e59fd7d0229be3ad90b29b2d0dc035ceeca666 BUG=chromium-os:11766 TEST=manual Adding an example to the test framework. Use make make runbmptests to ensure it works. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fc05bb8

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -21 lines)			Patch
	M	tests/bitmaps/NotReallyA.bmp	View		Binary file		0 comments	Download
	M	utility/bmpblk_utility.cc	View		5 chunks	+53 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages