Issue 6286144: Do not compile the unreachable body of functions with illegal redeclarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6286144: Do not compile the unreachable body of functions with illegal redeclarations. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32

Visibility:
Public.

Description

Do not compile the unreachable body of functions with illegal redeclarations. Revision 6635 added an assert on IA32 that there were no 'const' parameters. This assert could be hit at compile time because we compiled the unreachable body of functions with illegal redeclarations, which are thrown at runtime. Committed: http://code.google.com/p/v8/source/detail?r=6659

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
	M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+34 lines, -31 lines	0 comments	Download
	M	src/scopes.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages