Splits ChromeURLDataManager into 2 chunks:...

chrome/browser/profiles/profile.cc

Index: chrome/browser/profiles/profile.cc
===================================================================
--- chrome/browser/profiles/profile.cc	(revision 73990)
+++ chrome/browser/profiles/profile.cc	(working copy)
@@ -17,6 +17,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/chrome_blob_storage_context.h"
+#include "chrome/browser/dom_ui/chrome_url_data_manager.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/extensions/extension_message_service.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
@@ -619,6 +620,12 @@
     return NULL;
   }
 
+  virtual ChromeURLDataManager* GetChromeURLDataManager() {

[willchan no longer on Chromium, 2011/02/08 04:57:52]

Is this expensive to instantiate? Can we just create it during Profile
construction rather than use lazy instantiation?

[sky, 2011/02/08 05:35:26]

I don't think it's particularly expensive, but I don't think we should be
creating everything at construction time we might need. If we take that approach
with everything startup would be impacted. Additionally lazy instantiation is a
pretty common pattern in this class.

+    if (!chrome_url_data_manager_.get())
+      chrome_url_data_manager_.reset(new ChromeURLDataManager(this));
+    return chrome_url_data_manager_.get();
+  }
+
   virtual PromoCounter* GetInstantPromoCounter() {
     return NULL;
   }
@@ -708,6 +715,8 @@
 
   scoped_refptr<PrefProxyConfigTracker> pref_proxy_config_tracker_;
 
+  scoped_ptr<ChromeURLDataManager> chrome_url_data_manager_;
+
   DISALLOW_COPY_AND_ASSIGN(OffTheRecordProfileImpl);
 };