Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2233)

Unified Diff: ppapi/c/dev/ppb_file_chooser_dev.h

Issue 6286128: Pepper: Make PPB_FileChooser_Dev::Show "return" PP_ERROR_USERCANCEL if no file is selected. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppb_file_chooser_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/dev/ppb_file_chooser_dev.h
diff --git a/ppapi/c/dev/ppb_file_chooser_dev.h b/ppapi/c/dev/ppb_file_chooser_dev.h
index 0a43d11372ab97913057787791f538634f65ef1c..ebaa17b9c4161ed62ccab388d9f301ee76e6ceaf 100644
--- a/ppapi/c/dev/ppb_file_chooser_dev.h
+++ b/ppapi/c/dev/ppb_file_chooser_dev.h
@@ -23,7 +23,8 @@ struct PP_FileChooserOptions_Dev {
PP_FileChooserMode_Dev mode;
// A comma-separated list of MIME types such as audio/*,text/plain. The
- // dialog may restrict selectable files to the specified MIME types.
+ // dialog may restrict selectable files to the specified MIME types. Null may
+ // be given to indicate that all types should be accepted.
// TODO(darin): What if the mime type is unknown to the system? The plugin
// may wish to describe the mime type and provide a matching file extension.
// It is more webby to use mime types here instead of file extensions.
@@ -51,7 +52,9 @@ struct PPB_FileChooser_Dev {
// if the resource is invalid or some type other than a FileChooser.
PP_Bool (*IsFileChooser)(PP_Resource resource);
- // Prompts the user to choose a file or files.
+ // Prompts the user to choose a file or files. The callback is called with
+ // PP_OK on successful completion with a file (or files) selected or
+ // PP_ERROR_USERCANCEL if the user selected no file.
int32_t (*Show)(PP_Resource chooser, struct PP_CompletionCallback callback);
// After a successful call to Show, this method may be used to query the
@@ -65,4 +68,3 @@ struct PPB_FileChooser_Dev {
};
#endif /* PPAPI_C_DEV_PPB_FILE_CHOOSER_DEV_H_ */
-
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppb_file_chooser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698