Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 6286084: Verify that SCRIPTS_DIR exists in build_image. (Closed)

Created:
9 years, 10 months ago by davidjames
Modified:
9 years, 4 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa
Visibility:
Public.

Description

Verify that SCRIPTS_DIR exists in build_image. This hack is necessary for old chroots to ensure that we source a good common.sh when the one inside the chroot is out of date. We'll be able to get rid of this after everybody has updated their chroot to have a working version of common.sh and/or we have deprecated running scripts from the source directory. Also fix logic for when common.sh is missing to exit properly. BUG=chromium-os:11598 TEST=Verify that build_image still works when the old common.sh is present in the chroot. Change-Id: I2e8c2fd5ad06446e669ad665ee2e70f4364958fe Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=17d44e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build_image View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
9 years, 10 months ago (2011-02-03 18:32:30 UTC) #1
anush
9 years, 10 months ago (2011-02-03 19:33:54 UTC) #2
LGTM
On 2011/02/03 18:32:30, davidjames wrote:

Powered by Google App Engine
This is Rietveld 408576698