Remove all uses of the global Dispatcher Get function.

Rent syncemove all uses of the global Dispatcher Get function.

This reqired reworking how plugin->host GetInterface works. Previously,
interface requests were symmetric where each side would first do a
SupportsInterface to see if the remote side supports the interface, then create
the proxy. Since the plugin may talk to multiple renderers, we don't know where
to send these requests. The solution is to make the assumption that the
renderer always supports all PPB interfaces (which is possible since the proxy
is compiled with the executable).

This also adds some better lookup for interfaces to avoid having multiple lists
of interfaces. We now have a list of interfaces and factory functions in
dispatcher.cc.

Add some additional testing infrastructure for the dispatchers with simple tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74121

[piman, 2011-02-07 21:29:21]

The bulk of it looks good.
I have a couple of comments, and it seems to be missing the Context3D/Surface3D
interfaces.

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/interface_proxy.h
File ppapi/proxy/interface_proxy.h (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/interface_proxy....
ppapi/proxy/interface_proxy.h:41: InterfaceProxy::Factory create;
create->create_proxy ?

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/plugin_dispatche...
File ppapi/proxy/plugin_dispatcher.cc (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/plugin_dispatche...
ppapi/proxy/plugin_dispatcher.cc:107: // isn't supposed to happen.
Should we just crash here ? To prevent a compromised renderer from escalating
privilege ?

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppapi_proxy_test.cc
File ppapi/proxy/ppapi_proxy_test.cc (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppapi_proxy_test...
ppapi/proxy/ppapi_proxy_test.cc:77: // PluginProxyTes
--------------------------------------------------------------
typo: PluginProxyTest

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppp_instance_pro...
File ppapi/proxy/ppp_instance_proxy.cc (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppp_instance_pro...
ppapi/proxy/ppp_instance_proxy.cc:167:
plugin_dispatcher->DidCreateInstance(instance);
Maybe we can combine SetForInstance and DidCreateInstance ?
Similarly below, RemoveForInstance/DidDestroyInstance.

[brettw, 2011-02-08 00:28:04]

Thanks, new snap up including the 3D interfaces and a few forgotten files from
the previous CL.

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/plugin_dispatche...
File ppapi/proxy/plugin_dispatcher.cc (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/plugin_dispatche...
ppapi/proxy/plugin_dispatcher.cc:107: // isn't supposed to happen.
Sure.

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppp_instance_pro...
File ppapi/proxy/ppp_instance_proxy.cc (right):

http://codereview.chromium.org/6286070/diff/3014/ppapi/proxy/ppp_instance_pro...
ppapi/proxy/ppp_instance_proxy.cc:167:
plugin_dispatcher->DidCreateInstance(instance);
Good idea.

[piman, 2011-02-08 00:35:46]

LGTM