Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: enter_chroot.sh

Issue 6286069: Don't use sudo -v, which was having issues (hanging bots). (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: enter_chroot.sh
diff --git a/enter_chroot.sh b/enter_chroot.sh
index 91df62ca8023399e678b768d2cb2f66d53cd5de9..aa6a45bee88669a6a57d84089aa0bf8618220059 100755
--- a/enter_chroot.sh
+++ b/enter_chroot.sh
@@ -127,7 +127,8 @@ LOCKFILE="$FLAGS_chroot/var/lock/enter_chroot"
function setup_env {
# Validate sudo timestamp before entering the critical section so that we
# don't stall for a password while we have the lockfile.
- sudo -v
+ # Don't use sudo -v since that has issues on machines w/ no password.
+ sudo echo "" > /dev/null
(
flock 200
@@ -238,7 +239,8 @@ function setup_env {
function teardown_env {
# Validate sudo timestamp before entering the critical section so that we
# don't stall for a password while we have the lockfile.
- sudo -v
+ # Don't use sudo -v since that has issues on machines w/ no password.
+ sudo echo "" > /dev/null
# Only teardown if we're the last enter_chroot to die
(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698