src/ia32/full-codegen-ia32.cc - Issue 6286043: Direct call to eval passes strict mode through.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 6286043: Direct call to eval passes strict mode through. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code review feedback. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 3ef815912fbb94fddce3ff1d4bd6a1bdf3719ebb..7d1e6439e6773c5501d8a53396e36e3b80622907 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2270,7 +2270,9 @@ void FullCodeGenerator::VisitCall(Call* expr) {

// Push the receiver of the enclosing function and do runtime call.

__ push(Operand(ebp, (2 + scope()->num_parameters()) * kPointerSize));

- __ CallRuntime(Runtime::kResolvePossiblyDirectEval, 3);

+ // Push the strict mode flag.

+ __ push(Immediate(Smi::FromInt(strict_mode_flag())));

+ __ CallRuntime(Runtime::kResolvePossiblyDirectEval, 4);

// The runtime call returns a pair of values in eax (function) and

// edx (receiver). Touch up the stack with the right values.

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »