Direct call to eval passes strict mode through.

test/mjsunit/strict-mode-eval.js

Index: test/mjsunit/strict-mode-eval.js
diff --git a/test/mjsunit/strict-mode-eval.js b/test/mjsunit/strict-mode-eval.js
new file mode 100644
index 0000000000000000000000000000000000000000..9e5522646d9ca20df730e41aec61732da11c8285
--- /dev/null
+++ b/test/mjsunit/strict-mode-eval.js
@@ -0,0 +1,76 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+"use strict";
+
+function outer1() {
+  var no_exc = true;

[Lasse Reichstein, 2011/02/03 12:10:41]

is "exc" short for "exception"?
I typically see "exn" for that (not that it's much better, just spell it all
out).

[Martin Maly, 2011/02/04 01:02:34]

Done.

+  try {
+    eval("function f(eval) {}");
+    no_exc = false;

[Lasse Reichstein, 2011/02/03 12:10:41]

Just use
 assertUnreachable("did not throw exception")
here.

[Martin Maly, 2011/02/04 01:02:34]

Done.

+  } catch (e) {
+    assertInstanceof(e, SyntaxError);
+  }
+  assertTrue(no_exc, "did not throw exception");
+
+  function outer2() {
+    var no_exc = true;
+    try {
+      eval("function f(a, a) {}");
+      no_exc = false;
+    } catch (e) {
+      assertInstanceof(e, SyntaxError);
+    }
+    assertTrue(no_exc, "did not throw exception");
+
+    function outer3() {
+      var no_exc = true;
+      try {
+        eval("var x = '\\020;");

[Lasse Reichstein, 2011/02/03 12:10:41]

The string looks unterminated. You are probably not getting the octal-escape
SyntaxError.

Perhaps make check for each argument to eval that it is not an error in
non-strict mode.

Why the nested functions?

[Martin Maly, 2011/02/04 01:02:34]

The nested functions exercise the lazy compilation. Strictly speaking the 4
levels are not necessary but it tests yet another facet of the code.

On 2011/02/03 12:10:41, Lasse Reichstein wrote:

+        no_exc = false;
+      } catch (e) {
+        assertInstanceof(e, SyntaxError);
+      }
+      assertTrue(no_exc, "did not throw exception");
+
+      function outer4() {
+        var no_exc = true;
+        try {
+          eval("function eval() {}");
+          no_exc = false;
+        } catch (e) {
+          assertInstanceof(e, SyntaxError);
+        }
+        assertTrue(no_exc, "did not throw exception");
+      }
+      outer4();
+    }
+    outer3();
+  }
+  outer2();
+}
+outer1();