Better security checks when accessing named properties via Object.getOwnPropertyDescriptor.

Better security checks when accessing named properties via Object.getOwnPropertyDescriptor.

Current approach returns undefined descriptor if caller is not granted v8::HAS_ACCESS.
If the caller has v8::HAS_ACCESS, for no JS accessors regular v8::GET_ACCESS check is
performed and value property of the descriptor is set to undefined if caller doesn't
have proper access.  For JS accessors both v8::GET_ACCESS and v8::SET_ACCESS are checked
and affect if getter and setter would be stored in the descriptor.

Committed: http://code.google.com/p/v8/source/detail?r=6592

[antonm, 2011-02-01 19:18:57]

Mads and Rico,

next variation.  May you have a look?

[Mads Ager (chromium), 2011-02-02 10:13:36]

LGTM

http://codereview.chromium.org/6286020/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6286020/diff/1/src/runtime.cc#newcode677
src/runtime.cc:677: // The only hope there is an access exception.
I don't understand the comment. Could you expand on it?

[antonm, 2011-02-02 12:16:31]

Mads,

may you have a quick look at new wording?

http://codereview.chromium.org/6286020/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6286020/diff/1/src/runtime.cc#newcode677
src/runtime.cc:677: // The only hope there is an access exception.
On 2011/02/02 10:13:36, Mads Ager wrote:
> I don't understand the comment. Could you expand on it?

Sorry.  Is new wording better?

[Mads Ager (chromium), 2011-02-02 12:28:10]

Yes, thanks. LGTM