Refactoring of upload, form saving, and UMA logging.

chrome/browser/autofill/personal_data_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
@@ skipping 506 matching lines @@
   autofill_test::CreateTestFormField(
       "First name:", "first_name", "George", "text", &field);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Last name:", "last_name", "Washington", "text", &field);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Email:", "email", "theprez@gmail.com", "text", &field);
   form.fields.push_back(field);
   FormStructure form_structure(form);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 12 matching lines @@
   autofill_test::CreateTestFormField(
       "First name:", "first_name", "George", "text", &field);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Last name:", "last_name", "Washington", "text", &field);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Card number:", "card_number", "4111 1111 1111 1111", "text", &field);
   form.fields.push_back(field);
   FormStructure form_structure(form);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure);
   EXPECT_FALSE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   const std::vector<AutoFillProfile*>& profiles = personal_data_->profiles();
   ASSERT_EQ(0U, profiles.size());
   const std::vector<CreditCard*>& credit_cards = personal_data_->credit_cards();
@@ skipping 15 matching lines @@
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Phone #:", "home_phone_prefix", "555", "text", &field);
   field.set_max_length(3);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Phone #:", "home_phone_suffix", "0000", "text", &field);
   field.set_max_length(4);
   form.fields.push_back(field);
   FormStructure form_structure(form);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 72 matching lines @@
       "First name:", "first_name", "George", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Last name:", "last_name", "Washington", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Email:", "email", "theprez@gmail.com", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 55 matching lines @@
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Email:", "email", "theprez@gmail.com", "text", &field);
   form1.fields.push_back(field);
   // Phone gets updated.
   autofill_test::CreateTestFormField(
       "Phone:", "phone", "4445556666", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 58 matching lines @@
       "First name:", "first_name", "George", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Last name:", "last_name", "Washington", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Email:", "email", "theprez@gmail.com", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 56 matching lines @@
       "Last name:", "last_name", "Washington", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Company:", "company", "Government", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Email:", "email", "theprez@gmail.com", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
   AutoFillProfile expected;
@@ skipping 47 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 52 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 44 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 54 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 45 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 45 matching lines @@
       "Card Number:", "card_number", "4111-1111-1111-1111", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Month:", "exp_month", "01", "text", &field);
   form1.fields.push_back(field);
   autofill_test::CreateTestFormField(
       "Exp Year:", "exp_year", "2011", "text", &field);
   form1.fields.push_back(field);
 
   FormStructure form_structure1(form1);
-  std::vector<FormStructure*> forms;
+  std::vector<const FormStructure*> forms;
   forms.push_back(&form_structure1);
   EXPECT_TRUE(personal_data_->ImportFormData(forms));
   personal_data_->SaveImportedCreditCard();
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   MessageLoop::current()->Run();
 
@@ skipping 34 matching lines @@
 
   // Expect that the newer information is saved.  In this case the year is
   // added to the existing credit card.
   CreditCard expected2;
   autofill_test::SetCreditCardInfo(&expected2,
       "L1", "Biggie Smalls", "4111111111111111", "01", "2011");
   const std::vector<CreditCard*>& results2 = personal_data_->credit_cards();
   ASSERT_EQ(1U, results2.size());
   EXPECT_EQ(0, expected2.Compare(*results2[0]));
 }