Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 6286002: Add dataType=string to <select> elements with 'pref' attribute, if missing. (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
mazda
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add dataType=string to <select> elements with 'pref' attribute, if missing. dataType has been required for <select pref=...> since http://src.chromium.org/viewvc/chrome?view=rev&revision=71284 BUG=to be filed TEST=confirmed that the punctuation style setting worked for mozc. also confirmed that all <select> elements with 'pref' attribute have dataType: % perl -n0e 's/(<select[^>]*pref.*?>)/print "$ARGV:$1\n"/gse' *.html > all_select_prefs % perl -n0e 's/(<select[^>]*dataType.*?>)/print "$ARGV:$1\n"/gse' *.html > select_prefs_with_datatype % diff all_select_prefs select_prefs_with_datatype Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/resources/options/chromeos_language_chewing_options.html View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos_language_hangul_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos_language_mozc_options.html View 9 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos_language_pinyin_options.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
9 years, 11 months ago (2011-01-17 09:01:28 UTC) #1
mazda
lgtm
9 years, 11 months ago (2011-01-17 09:03:59 UTC) #2
satorux1
9 years, 11 months ago (2011-01-18 04:39:03 UTC) #3
Forgot to update BUG= line... Here is the bug:

http://code.google.com/p/chromium-os/issues/detail?id=11012

Powered by Google App Engine
This is Rietveld 408576698