DOMUI: Use dispatchSimpleEvent instead of programatically clicking the checkbox

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   // State variables.
   var syncEnabled = false;
@@ skipping 82 matching lines @@
     },
 
     /**
      * Updates the sync datatype checkboxes based on the selected sync option.
      * @private
      */
     updateSyncSelection_: function() {
       var idx = $('sync-select').selectedIndex;
       var syncCheckboxes = $('sync-table').getElementsByTagName('input');
       if (idx == 0) {
+        // 'Choose what to sync.'
         for (var i = 0; i < syncCheckboxes.length; i++) {
           syncCheckboxes[i].disabled = false;
         }
       } else if (idx == 1) {
+        // 'Everything' is synced.
         for (var i = 0; i < syncCheckboxes.length; i++) {
+          syncCheckboxes[i].checked = true;
+          syncCheckboxes[i].disabled = true;
+
           // Merely setting checked = true is not enough to trigger the pref
-          // being set; thus, we simulate the click.
-          if (!syncCheckboxes[i].checked)
-            syncCheckboxes[i].click();
-
-          syncCheckboxes[i].disabled = true;
+          // being set; thus, we dispatch a change even to notify PrefCheckbox
+          // |checked| has changed.
+          cr.dispatchSimpleEvent(syncCheckboxes[i], 'change')

[stuartmorgan, 2011/01/20 18:19:42]

Shouldn't you only send this if it wasn't previous checked?

[James Hawkins, 2011/01/20 18:25:13]

Done.

         }
       }
     },
 
     showStopSyncingOverlay_: function(event) {
       AlertOverlay.show(localStrings.getString('stop_syncing_title'),
                         localStrings.getString('stop_syncing_explanation'),
                         localStrings.getString('stop_syncing_confirm'),
                         localStrings.getString('cancel'),
                         function() { chrome.send('stopSyncing'); });
@@ skipping 114 matching lines @@
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });