Issue 6284003: Modify a method that was added mid-refactoring so that it follows the new structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6284003: Modify a method that was added mid-refactoring so that it follows the new structure. (Closed)

Created:
9 years, 11 months ago by Alex Nicolaou

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Modify a method that was added mid-refactoring so that it follows the new structure. BUG=none TEST=manually, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71760

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -11 lines)			Patch
M	chrome/browser/ui/views/tab_contents/tab_contents_container.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_container_native.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_container_views.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Alex Nicolaou

This came up because you checked in this function while I was refactoring the same ...

9 years, 11 months ago (2011-01-19 00:45:14 UTC) #1

LGTM