Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 6284002: Fix a ChromeFrame Back Forward navigation issue which occurs when we modify t... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix a ChromeFrame Back Forward navigation issue which occurs when we modify the IE history while processing a navigation update received for a tab loading state change. This is incorrectly treated as an internal navigation which messes up the history. Fix is to not treat the tab loading state change notification as an internal navigation. Fixes bug http://code.google.com/p/chromium/issues/detail?id=69096 BUG=69096 TEST=None at this point. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome_frame/chrome_active_document.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 6 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 11 months ago (2011-01-14 00:28:15 UTC) #1
amit
9 years, 11 months ago (2011-01-14 22:42:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698