Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 6283012: Do not shuffle parameters when doing sub on ia32 and arm. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 } else { 1287 } else {
1288 return DoArithmeticT(Token::MUL, instr); 1288 return DoArithmeticT(Token::MUL, instr);
1289 } 1289 }
1290 } 1290 }
1291 1291
1292 1292
1293 LInstruction* LChunkBuilder::DoSub(HSub* instr) { 1293 LInstruction* LChunkBuilder::DoSub(HSub* instr) {
1294 if (instr->representation().IsInteger32()) { 1294 if (instr->representation().IsInteger32()) {
1295 ASSERT(instr->left()->representation().IsInteger32()); 1295 ASSERT(instr->left()->representation().IsInteger32());
1296 ASSERT(instr->right()->representation().IsInteger32()); 1296 ASSERT(instr->right()->representation().IsInteger32());
1297 LOperand* left = UseRegisterAtStart(instr->LeastConstantOperand()); 1297 LOperand* left = UseRegisterAtStart(instr->left());
1298 LOperand* right = UseOrConstantAtStart(instr->MostConstantOperand()); 1298 LOperand* right = UseOrConstantAtStart(instr->right());
1299 LSubI* sub = new LSubI(left, right); 1299 LSubI* sub = new LSubI(left, right);
1300 LInstruction* result = DefineSameAsFirst(sub); 1300 LInstruction* result = DefineSameAsFirst(sub);
1301 if (instr->CheckFlag(HValue::kCanOverflow)) { 1301 if (instr->CheckFlag(HValue::kCanOverflow)) {
1302 result = AssignEnvironment(result); 1302 result = AssignEnvironment(result);
1303 } 1303 }
1304 return result; 1304 return result;
1305 } else if (instr->representation().IsDouble()) { 1305 } else if (instr->representation().IsDouble()) {
1306 return DoArithmeticD(Token::SUB, instr); 1306 return DoArithmeticD(Token::SUB, instr);
1307 } else { 1307 } else {
1308 return DoArithmeticT(Token::SUB, instr); 1308 return DoArithmeticT(Token::SUB, instr);
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
1841 1841
1842 1842
1843 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1843 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1844 HEnvironment* outer = current_block_->last_environment()->outer(); 1844 HEnvironment* outer = current_block_->last_environment()->outer();
1845 current_block_->UpdateEnvironment(outer); 1845 current_block_->UpdateEnvironment(outer);
1846 return NULL; 1846 return NULL;
1847 } 1847 }
1848 1848
1849 1849
1850 } } // namespace v8::internal 1850 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698