Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 6283010: Shifted code for CheckInternetZoneIdentifier into its own test so its flakiness (Closed)

Created:
9 years, 11 months ago by Randy Smith (Not in Mondays)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Shifted code for CheckInternetZoneIdentifier into its own test so its flakiness doesn't poison rest of the browser tests. BUG=20809 TEST=All DownloadTest.* browser tests pass except for 20809 specific one (windows) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M chrome/browser/download/download_browsertest.cc View 14 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Randy Smith (Not in Mondays)
Andy, Pawel: Could you take a quick look at this for me? I don't think ...
9 years, 11 months ago (2011-01-23 17:48:46 UTC) #1
ahendrickson
LGTM. On 2011/01/23 17:48:46, rdsmith wrote: > Andy, Pawel: Could you take a quick look ...
9 years, 11 months ago (2011-01-23 20:52:31 UTC) #2
Paweł Hajdan Jr.
9 years, 11 months ago (2011-01-24 08:55:40 UTC) #3
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698