Issue 6283009: Unregister access notifications when accessibility is turned off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6283009: Unregister access notifications when accessibility is turned off (Closed)

Created:
9 years, 11 months ago by Chaitanya

Modified:
9 years, 6 months ago

Reviewers:
dmazzoni, oshima

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Unregister access notifications when accessibility is turned off Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72244

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/login/wizard_accessibility_helper.cc	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

9 years, 11 months ago (2011-01-22 00:33:28 UTC) #3

LGTM

Please consider to replace gchar* stuff to string16&. Not so high priority,
but gchar* should die. (and gboolean as well).

- oshima

On Fri, Jan 21, 2011 at 4:24 PM, <dmazzoni@chromium.org> wrote:

> LGTM.
>
>
>
> http://codereview.chromium.org/6283009/
>

Expand Messages | Collapse Messages