Issue 6283008: views: Move the implementation of TabbedPaneExample from the header file to the source file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6283008: views: Move the implementation of TabbedPaneExample from the header file to the source file. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews

Visibility:
Public.

Description

views: Move the implementation of TabbedPaneExample from the header file to the source file. BUG=None TEST=run out/Debug/views_examples, it should work as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72211

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -76 lines)			Patch
M	views/examples/tabbed_pane_example.h	View	2 chunks	+14 lines, -76 lines	0 comments	Download
A	views/examples/tabbed_pane_example.cc	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	views/views.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

9 years, 11 months ago (2011-01-21 17:01:57 UTC) #2

LGTM

On Fri, Jan 21, 2011 at 8:50 AM, <tfarina@chromium.org> wrote:

> Reviewers: oshima,
>
> Message:
> Please, take a look.
>
> Description:
> views: Move the implementation of TabbedPaneExample from the header file to
> the
> source file.
>
> BUG=None
> TEST=run out/Debug/views_examples, it should work as before.
>
> Please review this at http://codereview.chromium.org/6283008/
>
> Affected files:
>  M views/examples/tabbed_pane_example.h
>  A views/examples/tabbed_pane_example.cc
>  M views/views.gyp
>
>
>

Expand Messages | Collapse Messages