ARM: Implement HasInstanceType in lithium backend.

ARM: Implement HasInstanceType in lithium backend.

Committed: http://code.google.com/p/v8/source/detail?r=6398

[Søren Thygesen Gjesse, 2011-01-19 12:55:00]

http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1785: Label done, is_false;
done currently not used.

http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1786: __ b(eq, &is_false);
There is a JumpIfSmi in ARM macro assembler.

But, is_false is not bound, how about

__ LoadRoot(result, Heap::kFalseValueRootIndex, eq);
__ b(eq, &done);

(then JumpIfSmi cannot be used).

[Mads Ager (chromium), 2011-01-19 13:00:58]

On 2011/01/19 12:55:00, Søren Gjesse wrote:
> http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc
> File src/arm/lithium-codegen-arm.cc (right):
> 
>
http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc#...
> src/arm/lithium-codegen-arm.cc:1785: Label done, is_false;
> done currently not used.
> 
>
http://codereview.chromium.org/6283006/diff/1/src/arm/lithium-codegen-arm.cc#...
> src/arm/lithium-codegen-arm.cc:1786: __ b(eq, &is_false);
> There is a JumpIfSmi in ARM macro assembler.
> 
> But, is_false is not bound, how about
> 
> __ LoadRoot(result, Heap::kFalseValueRootIndex, eq);
> __ b(eq, &done);
> 
> (then JumpIfSmi cannot be used).

D'oh! Fixed.

[Søren Thygesen Gjesse, 2011-01-19 13:03:10]

LGTM