Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6283005: [Mac] Move all the related files for the Wrench menu into a subdir of c/b/u/c... (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Move all the related files for the Wrench menu into a subdir of c/b/u/c/. BUG=none TEST=compile and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71453

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -893 lines) Patch
D chrome/browser/ui/cocoa/menu_tracked_button.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/cocoa/menu_tracked_button.mm View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/ui/cocoa/menu_tracked_button_unittest.mm View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/ui/cocoa/menu_tracked_root_view.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/cocoa/menu_tracked_root_view.mm View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/ui/cocoa/menu_tracked_root_view_unittest.mm View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 1 chunk +1 line, -1 line 1 comment Download
D chrome/browser/ui/cocoa/wrench_menu_button_cell.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/cocoa/wrench_menu_button_cell.mm View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/cocoa/wrench_menu_button_cell_unittest.mm View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/cocoa/wrench_menu_controller.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/cocoa/wrench_menu_controller.mm View 1 chunk +0 lines, -222 lines 0 comments Download
D chrome/browser/ui/cocoa/wrench_menu_controller_unittest.mm View 1 chunk +0 lines, -84 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
9 years, 11 months ago (2011-01-14 16:48:31 UTC) #1
Avi (use Gerrit)
9 years, 11 months ago (2011-01-14 16:52:01 UTC) #2 
LGTM with nit.

http://codereview.chromium.org/6283005/diff/1/chrome/browser/ui/cocoa/wrench_...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
(right):

http://codereview.chromium.org/6283005/diff/1/chrome/browser/ui/cocoa/wrench_...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm:10:
#import "chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h"
Alphabetize.

Powered by Google App Engine
This is Rietveld 408576698