Remove TopSites::IsEnabled() as well as related dead code.

Remove TopSites::IsEnabled() as well as related dead code.

TopSites has been enabed since r64072. It's now time to remove
the dead code.

BUG=69492
TEST=Make sure thumbnails are correctly updated as before. try bots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71634

[sky, 2011-01-13 16:55:52]

Couple of other things to clean up:There is also a switch (kEnableTopSites) that
explicitly sets whether top sites is enabled. Nuke it too.

In dom_ui_thumbnail_source remove the include for history and change it to
TOpSites. You'll need to update OnThumbnailDataAvailable to take
TopSites::Handle. Also, remove the notification_registrary include as that isn't
needed either.

In most_visited_handler you should be able to remove OnSegmentUsageAvailable,
SetPagesValues, SetMostVisistedPage, url_blacklist_, pinned_urls_ now. There may
be a couple more methods. After you remove all those fields and methods make
sure there isn't additional things you can cleanup too. You should also be able
to remove the include of history.h.

Thumbnail_database should be renamed and the comments updated, but I can take
care of that separately.


Thanks!

  -Scott

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
File chrome/browser/history/history_backend_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
chrome/browser/history/history_backend_unittest.cc:21: #include
"chrome/browser/history/top_sites.h"
You should be able to remove this now.

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
File chrome/browser/history/history_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
chrome/browser/history/history_unittest.cc:48: #include
"chrome/browser/history/top_sites.h"
Can this be removed now?

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
File chrome/browser/history/thumbnail_database_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
chrome/browser/history/thumbnail_database_unittest.cc:17: #include
"chrome/browser/history/top_sites.h"
Can this be removed?

[satorux1, 2011-01-14 07:36:46]

Hi Scott,

Thank you for the comments. I've addressed your comment. Re
OnThumbnailDataAvailable, the function didn't use HistoryService::Handle
request_handle parameter at all, so I just needed to remove the parameter. :)

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
File chrome/browser/history/history_backend_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
chrome/browser/history/history_backend_unittest.cc:21: #include
"chrome/browser/history/top_sites.h"
On 2011/01/13 16:55:52, sky wrote:
> You should be able to remove this now.

Done.

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
File chrome/browser/history/history_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
chrome/browser/history/history_unittest.cc:48: #include
"chrome/browser/history/top_sites.h"
On 2011/01/13 16:55:52, sky wrote:
> Can this be removed now?

Done.

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
File chrome/browser/history/thumbnail_database_unittest.cc (right):

http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
chrome/browser/history/thumbnail_database_unittest.cc:17: #include
"chrome/browser/history/top_sites.h"
On 2011/01/13 16:55:52, sky wrote:
> Can this be removed?

Done.

[sky, 2011-01-14 16:28:05]

On Thu, Jan 13, 2011 at 11:36 PM,  <satorux@chromium.org> wrote:
> Hi Scott,
>
> Thank you for the comments. I've addressed your comment. Re
> OnThumbnailDataAvailable, the function didn't use HistoryService::Handle
> request_handle parameter at all, so I just needed to remove the parameter.

Actually, I think you can just remove that function now, as well as
cancelable_consumer_

LGTM once you do that change

  -Scott

> :)
>
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
> File chrome/browser/history/history_backend_unittest.cc (right):
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
> chrome/browser/history/history_backend_unittest.cc:21: #include
> "chrome/browser/history/top_sites.h"
> On 2011/01/13 16:55:52, sky wrote:
>>
>> You should be able to remove this now.
>
> Done.
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
> File chrome/browser/history/history_unittest.cc (right):
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/history_...
> chrome/browser/history/history_unittest.cc:48: #include
> "chrome/browser/history/top_sites.h"
> On 2011/01/13 16:55:52, sky wrote:
>>
>> Can this be removed now?
>
> Done.
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
> File chrome/browser/history/thumbnail_database_unittest.cc (right):
>
>
http://codereview.chromium.org/6283001/diff/1/chrome/browser/history/thumbnai...
> chrome/browser/history/thumbnail_database_unittest.cc:17: #include
> "chrome/browser/history/top_sites.h"
> On 2011/01/13 16:55:52, sky wrote:
>>
>> Can this be removed?
>
> Done.
>
> http://codereview.chromium.org/6283001/
>