Linux: make it possible to build with third_party/xdg-utils directory removed...

chrome/chrome_exe.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'chrome_exe_target': 0,
     },
     'target_conditions': [
@@ skipping 123 matching lines @@
     ],
   },
   'targets': [
     {
       'target_name': 'chrome',
       'type': 'executable',
       'mac_bundle': 1,
       'msvs_guid': '7B219FAA-E360-43C8-B341-804A94EEFFAC',
       'variables': {
         'chrome_exe_target': 1,
+        'use_system_xdg_utils%': 0,

[Mike Mammarella, 2011/01/18 18:17:19]

Would it be possible to put this constant along with the other similar constants
that control whether bundled stuff is used? It seems like it will be
increasingly annoying for distributions to patch all these changes into the gyp
files if the constants they're changing are scattered about.

       },
       'conditions': [
         ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
           'actions': [
             {
               'action_name': 'manpage',
               'conditions': [
                 [ 'branding == "Chrome"', {
                   'variables': {
                     'name': 'Google Chrome',
@@ skipping 26 matching lines @@
               'message': 'Generating manpage'
             },
           ],
           'conditions': [
             [ 'linux_use_tcmalloc==1', {
                 'dependencies': [
                   '<(allocator_target)',
                 ],
               },
             ],
+            ['use_system_xdg_utils==0', {
+              'copies': [
+                {
+                  'destination': '<(PRODUCT_DIR)',
+                  'files': ['tools/build/linux/chrome-wrapper',

[Mike Mammarella, 2011/01/18 18:17:19]

The chrome-wrapper script isn't part of xdg-utils; you probably want to copy it
below, not inside this condition. Maybe a separate condition for it is warranted
though, if distributions don't want this script either and have their own
version instead.

+                            '../third_party/xdg-utils/scripts/xdg-mime',
+                            '../third_party/xdg-utils/scripts/xdg-settings',
+                            ],
+                  # The wrapper script above may need to generate a .desktop
+                  # file, which requires an icon. So, copy one next to the
+                  # script.
+                  'conditions': [
+                    ['branding=="Chrome"', {
+                      'files': ['app/theme/google_chrome/product_logo_48.png']
+                    }, { # else: 'branding!="Chrome"
+                      'files': ['app/theme/chromium/product_logo_48.png']
+                    }],
+                  ],
+                },
+              ],
+            }],
           ],
           'dependencies': [
             # On Linux, link the dependencies (libraries) that make up actual
             # Chromium functionality directly into the executable.
             '<@(chromium_dependencies)',
             # Needed for chrome_main.cc initialization of libraries.
             '../build/linux/system.gyp:dbus-glib',
             '../build/linux/system.gyp:gtk',
             'packed_resources',
             # Needed to use the master_preferences functions
             'installer_util',
           ],
           'sources': [
             'app/chrome_main.cc',
             'app/chrome_dll_resource.h',
           ],
-          'copies': [
-            {
-              'destination': '<(PRODUCT_DIR)',
-              'files': ['tools/build/linux/chrome-wrapper',
-                        '../third_party/xdg-utils/scripts/xdg-mime',
-                        '../third_party/xdg-utils/scripts/xdg-settings',
-                        ],
-              # The wrapper script above may need to generate a .desktop file,
-              # which requires an icon. So, copy one next to the script.
-              'conditions': [
-                ['branding=="Chrome"', {
-                  'files': ['app/theme/google_chrome/product_logo_48.png']
-                }, { # else: 'branding!="Chrome"
-                  'files': ['app/theme/chromium/product_logo_48.png']
-                }],
-              ],
-            },
-          ],
         }],
         ['OS=="mac"', {
           # 'branding' is a variable defined in common.gypi
           # (e.g. "Chromium", "Chrome")
           'conditions': [
             ['branding=="Chrome"', {
               'mac_bundle_resources': [
                 'app/theme/google_chrome/app.icns',
                 'app/theme/google_chrome/document.icns',
                 'browser/ui/cocoa/applescript/scripting.sdef',
@@ skipping 275 matching lines @@
           'configurations': {
             'Common_Base': {
               'msvs_target_platform': 'x64',
             },
           },
         },
       ],
     }],
   ],
 }