Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/renderer/render_view.h

Issue 6282003: Remove obsolete WebViewClient::createView method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/autofill
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_ 5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
6 #define CHROME_RENDERER_RENDER_VIEW_H_ 6 #define CHROME_RENDERER_RENDER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 425
426 // Most methods are handled by RenderWidget. 426 // Most methods are handled by RenderWidget.
427 virtual void didFocus(); 427 virtual void didFocus();
428 virtual void didBlur(); 428 virtual void didBlur();
429 virtual void show(WebKit::WebNavigationPolicy policy); 429 virtual void show(WebKit::WebNavigationPolicy policy);
430 virtual void closeWidgetSoon(); 430 virtual void closeWidgetSoon();
431 virtual void runModal(); 431 virtual void runModal();
432 432
433 // WebKit::WebViewClient implementation -------------------------------------- 433 // WebKit::WebViewClient implementation --------------------------------------
434 434
435 // TODO(jochen): remove once webkit side is up to date.
436 virtual WebKit::WebView* createView(
437 WebKit::WebFrame* creator,
438 const WebKit::WebWindowFeatures& features,
439 const WebKit::WebString& frame_name);
440 virtual WebKit::WebView* createView( 435 virtual WebKit::WebView* createView(
441 WebKit::WebFrame* creator, 436 WebKit::WebFrame* creator,
442 const WebKit::WebURLRequest& request, 437 const WebKit::WebURLRequest& request,
443 const WebKit::WebWindowFeatures& features, 438 const WebKit::WebWindowFeatures& features,
444 const WebKit::WebString& frame_name); 439 const WebKit::WebString& frame_name);
445 virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type); 440 virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type);
446 virtual WebKit::WebWidget* createPopupMenu( 441 virtual WebKit::WebWidget* createPopupMenu(
447 const WebKit::WebPopupMenuInfo& info); 442 const WebKit::WebPopupMenuInfo& info);
448 virtual WebKit::WebExternalPopupMenu* createExternalPopupMenu( 443 virtual WebKit::WebExternalPopupMenu* createExternalPopupMenu(
449 const WebKit::WebPopupMenuInfo& popup_menu_info, 444 const WebKit::WebPopupMenuInfo& popup_menu_info,
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 // ADDING NEW DATA? Please see if it fits appropriately in one of the above 1525 // ADDING NEW DATA? Please see if it fits appropriately in one of the above
1531 // sections rather than throwing it randomly at the end. If you're adding a 1526 // sections rather than throwing it randomly at the end. If you're adding a
1532 // bunch of stuff, you should probably create a helper class and put your 1527 // bunch of stuff, you should probably create a helper class and put your
1533 // data and methods on that to avoid bloating RenderView more. 1528 // data and methods on that to avoid bloating RenderView more.
1534 // --------------------------------------------------------------------------- 1529 // ---------------------------------------------------------------------------
1535 1530
1536 DISALLOW_COPY_AND_ASSIGN(RenderView); 1531 DISALLOW_COPY_AND_ASSIGN(RenderView);
1537 }; 1532 };
1538 1533
1539 #endif // CHROME_RENDERER_RENDER_VIEW_H_ 1534 #endif // CHROME_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698