Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 6282001: Disable background network access in sync integration tests (Closed)

Created:
9 years, 11 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Disable background network access in sync integration tests Now that the sync integration tests are designed to be self-contained and not rely on external network resources like GAIA, we need to ensure that background network access for things like auto update is disabled. This patch adds the --disable-background-networking command line switch to the sync integration test framework. BUG=69469, 53931 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71338

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M chrome/test/live_sync/live_extensions_sync_test_base.cc View 1 chunk +0 lines, -4 lines 2 comments Download
M chrome/test/live_sync/live_sync_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 3 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
Fred, please review. Thanks.
9 years, 11 months ago (2011-01-13 02:40:39 UTC) #1
akalin
LGTM http://codereview.chromium.org/6282001/diff/1/chrome/test/live_sync/live_extensions_sync_test_base.cc File chrome/test/live_sync/live_extensions_sync_test_base.cc (left): http://codereview.chromium.org/6282001/diff/1/chrome/test/live_sync/live_extensions_sync_test_base.cc#oldcode111 chrome/test/live_sync/live_extensions_sync_test_base.cc:111: // TODO(akalin): Mock out the servers that the ...
9 years, 11 months ago (2011-01-13 04:40:07 UTC) #2
akalin
LGTM
9 years, 11 months ago (2011-01-13 04:51:57 UTC) #3
Raghu Simha
9 years, 11 months ago (2011-01-13 18:49:44 UTC) #4
http://codereview.chromium.org/6282001/diff/1/chrome/test/live_sync/live_exte...
File chrome/test/live_sync/live_extensions_sync_test_base.cc (left):

http://codereview.chromium.org/6282001/diff/1/chrome/test/live_sync/live_exte...
chrome/test/live_sync/live_extensions_sync_test_base.cc:111: // TODO(akalin):
Mock out the servers that the extensions
On 2011/01/13 04:40:07, akalin wrote:
> Leave this TODO in, but also add that background networking would need to be
> reenabled for extension tests.

Done.

Powered by Google App Engine
This is Rietveld 408576698