Issue 6282: Fixes crash in BrowserAccessibilityManager destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6282: Fixes crash in BrowserAccessibilityManager destructor. (Closed)

Created:
12 years, 2 months ago by Jonas Klink (Google)

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, mal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes crash in BrowserAccessibilityManager destructor (see CPBrowsingContextManager for example of this type of fix). Also fixes small style issue, to be consistent with other Singleton implementations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3078

Patch Set 1 #

Created: 12 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -12 lines)
M	chrome/browser/browser_accessibility.cc	View	1 chunk	+6 lines, -5 lines	0 comments
M	chrome/browser/browser_accessibility_manager.h	View	2 chunks	+2 lines, -2 lines	0 comments
M	chrome/browser/browser_accessibility_manager.cc	View	2 chunks	+3 lines, -3 lines	0 comments
M	chrome/browser/render_widget_host_hwnd.cc	View	1 chunk	+3 lines, -2 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jonas Klink (Google)

Jay, could you do a quick review on this crash bug fix that Mark reported?

12 years, 2 months ago (2008-10-07 02:19:18 UTC) #2

LGTM

Expand Messages | Collapse Messages