Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 6281009: Add a total startup counter (Closed)

Created:
9 years, 11 months ago by gavinp
Modified:
9 years, 6 months ago
Reviewers:
cbentzel, Robert Sesek
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add a total startup counter With this counter of all startups, you can now use metrics to compute ratios of sessions. Also add some UMA to the tracking file. TEST=not this time BUG= no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72277

Patch Set 1 : action! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/chromeactions.txt View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gavinp
With this new total count of startups, we can look at the metric for AboutFlag_page-prerender ...
9 years, 11 months ago (2011-01-21 20:14:48 UTC) #1
Robert Sesek
LGTM
9 years, 11 months ago (2011-01-21 20:15:45 UTC) #2
gavinp
Also: all the jibjab about OutdatedPluginInfobar is for Peter Kasting; he didn't run chome/tools/extract_actions.py --hash ...
9 years, 11 months ago (2011-01-21 20:17:03 UTC) #3
Peter Kasting
I didn't add, remove, or modify any actions. Why would I have needed to run ...
9 years, 11 months ago (2011-01-21 20:20:08 UTC) #4
cbentzel
For measuring prerender utilization I'd prefer a histogram since it's easier to track per-version as ...
9 years, 11 months ago (2011-01-21 20:25:58 UTC) #5
Robert Sesek
On Fri, Jan 21, 2011 at 3:25 PM, Chris Bentzel <cbentzel@chromium.org>wrote: > If the user ...
9 years, 11 months ago (2011-01-22 01:24:03 UTC) #6
gavinp
On 2011/01/21 20:25:58, cbentzel wrote: > For measuring prerender utilization I'd prefer a histogram since ...
9 years, 11 months ago (2011-01-22 14:10:29 UTC) #7
cbentzel
9 years, 11 months ago (2011-01-22 17:01:12 UTC) #8
Lgtm
On Jan 22, 2011 9:10 AM, <gavinp@chromium.org> wrote:
> On 2011/01/21 20:25:58, cbentzel wrote:
>> For measuring prerender utilization I'd prefer a histogram since it's
>> easier
>> to track per-version as well as make sure that FieldTrials work
correctly.
>
>> If the user action can be used for other purposes it's OK to keep in.
>
>> On Fri, Jan 21, 2011 at 3:20 PM, <mailto:pkasting@chromium.org> wrote:
>
>> > I didn't add, remove, or modify any actions. Why would I have needed to
>> > run
>> > extract_actions? Do you perhaps mean whoever it was that added those
>> > actions
>> > before me?
>> >
>> >
>> > http://codereview.chromium.org/6281009/
>> >
>
> Ok, I'll put together changes to also add an histogram, I think those are
> compelling reasons. I'll modify this issue to not refer to the histogram
> bug,
> and make a separate upload.
>
> I'll land this if it gets a cbentzel LGTM.
>
>
> http://codereview.chromium.org/6281009/

Powered by Google App Engine
This is Rietveld 408576698