Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 628009: Adding @@extension_id reserved message to l10n message map for extension.... (Closed)

Created:
10 years, 10 months ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw+cc_chromium.org, darin+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, kathyw
Visibility:
Public.

Description

Adding @@extension_id reserved message to l10n message map for extension. It's added outside of ExtensionMessageBundle so that non-localized extensions can use it. Developer doesn't have to define default_locale in the manifest in order to get it working. With this change every extension css file will go through message replacement process (only localized extensions went through that before). This change will allow following construct in extension css: body { background-image:url('chrome-extension://__MSG_@@extension_id__/background.png'); } BUG=35208 TEST=Add an background image to your extension, and refer to it from css file using __MSG_@@extension_id__. Image should show up in the background. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_message_bundle.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_message_filter_peer.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nebojša Ćirić
10 years, 10 months ago (2010-02-18 00:36:22 UTC) #1
Matt Perry
LGTM.
10 years, 10 months ago (2010-02-18 00:55:02 UTC) #2
Erik does not do reviews
10 years, 10 months ago (2010-02-18 01:14:27 UTC) #3
I'll defer to matt here.

Powered by Google App Engine
This is Rietveld 408576698