Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 6280013: Fix a bug in delete for lookup slots. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in delete for lookup slots. The function Runtime_LookupContext searches the context chain for a LOOKUP slot and returns the object holding the slot. It returned the global context if the slot was not found or if it was found in a function's context or arguments object. This is not the correct object to use for 'delete'. Since this lookup function is only ever used when deleting LOOKUP slots (those that have to go through a with or a scope with eval), it is simply replaced with a Runtime_DeleteContextSlot function that does the appropriate thing for all kinds of context lookups. This fixes Chromium bug 70066. http://code.google.com/p/chromium/issues/detail?id=70066 Committed: http://code.google.com/p/v8/source/detail?r=6442

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -54 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +25 lines, -12 lines 1 comment Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +5 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-70066.js View 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-24 13:10:02 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-24 13:15:19 UTC) #2
LGTM

http://codereview.chromium.org/6280013/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6280013/diff/1/src/runtime.cc#newcode7069
src/runtime.cc:7069: // If the slot was found in a context, it should be
DONT_DELETE.
Can we assert that this is always the case or is that just always implicitly the
case?

Powered by Google App Engine
This is Rietveld 408576698