Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 6280005: Fix Pepper URL Loader callbacks. (Closed)

Created:
9 years, 11 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix Pepper URL Loader callbacks. (Previously committed r71334, reverted r71400. Added null check pointed out by jam.) Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -43 lines) Patch
M ppapi/tests/test_file_io.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/tests/test_url_loader.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/tests/test_url_loader.cc View 6 chunks +67 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.h View 5 chunks +19 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 9 chunks +52 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
This is just what I had previously committed (and then reverted), with your additional fix ...
9 years, 11 months ago (2011-01-14 01:31:23 UTC) #1
jam
9 years, 11 months ago (2011-01-14 02:06:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698