Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 6280003: Password Autofill disables auto-completed textfield (Closed)

Created:
9 years, 11 months ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Password Autofill disables auto-completed textfield This change fixes an issue where the password completion, when the tab key is used to cycle focus, was causing focus to get lost. BUG=67888 TEST=PasswordAutocompleteManagerTest.*, and manual tests according to bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/renderer/password_autocomplete_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/password_autocomplete_manager.cc View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dhollowa
9 years, 11 months ago (2011-01-13 22:23:09 UTC) #1
Ilya Sherman
9 years, 11 months ago (2011-01-13 22:30:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698