Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 6279012: Implement pref policy for disabling incognito mode.... (Closed)

Created:
9 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implement pref policy for disabling incognito mode. 2nd attempt with shutdown crash fix (only difference is in browser.cc). BUG=66413 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72791

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M chrome/app/policy/policy_templates.json View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_win_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_store_interface.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 7 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/policy_constants.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/policy_constants.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
This is essentially the same CL, but with some changes to browser.cc.
9 years, 11 months ago (2011-01-26 18:48:32 UTC) #1
Mattias Nissler (ping if slow)
9 years, 11 months ago (2011-01-26 19:22:40 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698