Issue 6279011: IA32: Refactor common string add code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6279011: IA32: Refactor common string add code. (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

IA32: Refactor common string add code. Committed: http://code.google.com/p/v8/source/detail?r=6457

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -61 lines)			Patch
	M	src/ia32/code-stubs-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/ia32/code-stubs-ia32.cc	View	1	3 chunks	+38 lines, -61 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/6279011/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/6279011/diff/1/src/ia32/code-stubs-ia32.cc#newcode2365 src/ia32/code-stubs-ia32.cc:2365: Label call_runtime; Can this be a NearLabel since ...

9 years, 11 months ago (2011-01-25 11:55:16 UTC) #2

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-25 12:14:38 UTC) #3

http://codereview.chromium.org/6279011/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/6279011/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:2365: Label call_runtime;
On 2011/01/25 11:55:16, fschneider wrote:
> Can this be a NearLabel since it is only used here?

Done.

Expand Messages | Collapse Messages

Issue 6279011: IA32: Refactor common string add code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages