Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 6278013: Oops, fix my previous fix to the refactor breakage. Make sure we only apply... (Closed)

Created:
9 years, 11 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Oops, fix my previous fix to the refactor breakage. Make sure we only apply the current menu command to whoever opened the custom menu. We have to track it in a slightly ugly manner thanks to GTK's out-of-order messaging for "menu item selected" vs. "context menu closed". BUG=NONE TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/renderer/blocked_plugin.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
Feature works again.
9 years, 11 months ago (2011-01-21 23:07:40 UTC) #1
Cris Neckar
9 years, 11 months ago (2011-01-21 23:14:46 UTC) #2
pending green trybots LGTM

Powered by Google App Engine
This is Rietveld 408576698