dom-ui settings: Eliminate duplicate font names in WinChrome....

dom-ui settings: Eliminate duplicate font names in WinChrome.

BUG=69155
TEST=Verify font names list does not contain duplicates in WinChrome.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72822

[csilv, 2011-01-27 00:13:32]

+jhawkins for review

[James Hawkins, 2011-01-27 01:15:51]

http://codereview.chromium.org/6277022/diff/1/chrome/browser/dom_ui/options/f...
File chrome/browser/dom_ui/options/font_settings_utils_win.cc (right):

http://codereview.chromium.org/6277022/diff/1/chrome/browser/dom_ui/options/f...
chrome/browser/dom_ui/options/font_settings_utils_win.cc:45:
font_item->Append(Value::CreateStringValue(*iter));
Why Append() twice?

[csilv, 2011-01-27 01:18:23]

http://codereview.chromium.org/6277022/diff/1/chrome/browser/dom_ui/options/f...
File chrome/browser/dom_ui/options/font_settings_utils_win.cc (right):

http://codereview.chromium.org/6277022/diff/1/chrome/browser/dom_ui/options/f...
chrome/browser/dom_ui/options/font_settings_utils_win.cc:45:
font_item->Append(Value::CreateStringValue(*iter));
On 2011/01/27 01:15:51, James Hawkins wrote:
> Why Append() twice?

The font_item is a list that contains two items, a font name, and a localized
font name.  On Windows these appear to be the same.... whereas on Mac they are
different values.

[James Hawkins, 2011-01-27 17:33:38]

LGTM