Issue 6277016: Re-enable RenderViewTest.OnNavStateChanged now that the bug has been

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6277016: Re-enable RenderViewTest.OnNavStateChanged now that the bug has been (Closed)

Created:
9 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
jorlow, John Knottenbelt

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Re-enable RenderViewTest.OnNavStateChanged now that the bug has been fixed upstream. BUG=70408 TBR=jknotten,jorlow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72358

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/renderer/render_view_browsertest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

9 years, 11 months ago (2011-01-24 19:19:22 UTC) #2

LGTM


On Mon, Jan 24, 2011 at 11:08 AM, <tony@chromium.org> wrote:

> Reviewers: John Knottenbelt, jorlow,
>
> Description:
> Re-enable RenderViewTest.OnNavStateChanged now that the bug has been
> fixed upstream.
>
> BUG=70408
> TBR=jknotten,jorlow
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72358
>
> Please review this at http://codereview.chromium.org/6277016/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/renderer/render_view_browsertest.cc
>
>
> Index: chrome/renderer/render_view_browsertest.cc
> diff --git a/chrome/renderer/render_view_browsertest.cc
> b/chrome/renderer/render_view_browsertest.cc
> index
>
05264c6db4316dfbeb8b37950edd58040355aa9d..c44174df04f5c0033ae4b9b37b94d4723f70228f
> 100644
> --- a/chrome/renderer/render_view_browsertest.cc
> +++ b/chrome/renderer/render_view_browsertest.cc
> @@ -46,9 +46,8 @@ const int kDefaultMaxLength = 0x80000;
>
>  }  // namespace
>
> -// TODO(jknotten). Fix
> http://code.google.com/p/chromium/issues/detail?id=70408
>  // Test that we get form state change notifications when input fields
> change.
> -TEST_F(RenderViewTest, DISABLED_OnNavStateChanged) {
> +TEST_F(RenderViewTest, OnNavStateChanged) {
>   // Don't want any delay for form state sync changes. This will still post
> a
>   // message so updates will get coalesced, but as soon as we spin the
> message
>   // loop, it will generate an update.
>
>
>

Expand Messages | Collapse Messages